release-19.2: storage: remove the replica up to date check when transferring lease #42761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we had a check that filtered out all replicas that are lagging behind the leader in case of a lease transfer. We had to remove that check because when the lease preference specifies a node that is constantly lagging - the lease transfer will never occur. This removes the check that the cadidates for lease transfer are only replicas that aren't lagging behind. etcd implements the 3.10 Leadership transfer extension where the old leader will bring up to date the new leader's log while blocking any new requests. Release note (bug fix): now possible to transfer range leases to lagging replicas
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #42379.
/cc @cockroachdb/release
Previously, we had a check that filtered out all replicas that
are lagging behind the leader in case of a lease transfer.
We remove that check so in case of lease preference for
a node that is constantly lagging - the lease transfer can occur without delay.
This removes the check that the candidates for lease transfer are only
replicas that aren't lagging behind. etcd implements the
3.10 Leadership transfer extension where the old leader will
bring up to date the new leader's log while blocking any new requests.
Release note (bug fix): now possible to transfer range leases to lagging replicas