Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-19.2: colexec: fix unmarshaling Timestamp #42576

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented Nov 19, 2019

Backport 1/1 commits from #42575.

/cc @cockroachdb/release


When the support for Timestamp type was added to the vectorized engine,
one place was forgotten. Now this is fixed.

Release note (bug fix): Timestamp type is now fully supported by the
vectorized engine (previously, in some edge cases, an "unsupported type"
error would occur).

@yuzefovich yuzefovich requested a review from asubiotto November 19, 2019 19:29
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@asubiotto asubiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs a release note (sorry I didn't notice on master)

@yuzefovich
Copy link
Member Author

I didn't put the release note intentionally since I thought that the problem was introduced after the last releases, but now I realize that 19.2.1 release process has been started already (and alpha for 20.1 was actually released), so it probably deserves a release note to be included for 19.2.2.

When the support for Timestamp type was added to the vectorized engine,
one place was forgotten. Now this is fixed.

Release note (bug fix): Timestamp type is now fully supported by the
vectorized engine (previously, in some edge cases, an "unsupported type"
error would occur).
@yuzefovich yuzefovich merged commit b838a08 into cockroachdb:release-19.2 Nov 19, 2019
@yuzefovich yuzefovich deleted the backport19.2-42575 branch November 19, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants