sql: fix assignment of dropped table job status #42121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were mistakenly mutating a copy of a slice element in a loop while updating the status for a job for a table drop, causing an incorrect job status to be reported. Release note (bug fix): A bug was fixed that caused jobs for dropping tables to report an inaccurate status.
|
This change is |
dt
approved these changes
Nov 1, 2019
|
bors r+ |
Build failed |
|
UI test flake bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 1, 2019
42118: Revert "importccl: small refactor of unnecessary loop" r=dt a=danhhz This reverts commit 2e24bf9. This refactor had an unintentional change of behavior. Before there were numCPU workers all collaborating to produce the rows between BatchBegin and BatchEnd. After there are numCPU _each_ producing the rows between BatchBegin and BatchEnd. This means we're importing numCPU duplicates of every kv. I am incredibly surprised that no tests broke, this points to a big hole in our test coverage. I think it was "working" because we require workload implementations to be totally deterministic and AddSSTable has to be resilient to replaying an exact request? Release note: none 42121: sql: fix assignment of dropped table job status r=lucy-zhang a=lucy-zhang We were mistakenly mutating a copy of a slice element in a loop while updating the status for a job for a table drop, causing an incorrect job status to be reported. Fixes #39347. Release note (bug fix): A bug was fixed that caused jobs for dropping tables to report an inaccurate status. Co-authored-by: Daniel Harrison <[email protected]> Co-authored-by: Lucy Zhang <[email protected]>
Build succeeded |
|
candidate for a 19.2 backport? |
|
I don't know, this doesn't seem very high-impact. I think it only affects the displayed job status and nothing about the running of the job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were mistakenly mutating a copy of a slice element in a loop while updating
the status for a job for a table drop, causing an incorrect job status to be
reported.
Fixes #39347.
Release note (bug fix): A bug was fixed that caused jobs for dropping tables to
report an inaccurate status.