release-19.2: storage: check whether the acquiring replica can receive the lease #42079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Just waiting on TeamCity on #42068 to pass before I bors it. |
|
and it passed. |
nvanbenschoten
approved these changes
Oct 31, 2019
Before this PR, when evaluating lease transfers or requests we'd check whether the evaluating replica could receive the lease rather than the acquiring replica. This patch fixes that bug by checking the state of the correct replica. Release note (bug fix): The system no longer erroneously transfers leases to replicas which are in the process of being removed which can lead to ranges being effectively unavailable due to an invalid lease.
ajwerner
force-pushed
the
backport19.2-42068
branch
from
27aedb8 to
cd806c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #42068.
/cc @cockroachdb/release
Before this PR, when evaluating lease transfers or requests we'd check whether
the evaluating replica could receive the lease rather than the acquiring
replica. This patch fixes that bug by checking the state of the correct
replica.
Fixes #38720.
Release note (bug fix): The system no longer erroneously transfers leases
to replicas which are in the process of being removed which can lead to
ranges being effectively unavailable due to an invalid lease.