sqlsmith: fix merge join to exit when it's out of indexes #41579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
|
This change is |
jordanlewis
approved these changes
Oct 14, 2019
|
The loop is finding equal prefixes in two indexes. Previously it would be fine if the right index had more columns than the left index because we were looping over the left. But if the left index had more columns it would error when attempting to index into the right index. This new check makes sure the right index is long enough to keep looping. |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 14, 2019
41577: storage: Deflake TestReplicateRogueRemovedNode r=ajwerner a=bdarnell Some recently-refactored test harness code needed to check for nil stores. Fixes #41466 Release note: None 41579: sqlsmith: fix merge join to exit when it's out of indexes r=mjibson a=mjibson Release note: None Co-authored-by: Ben Darnell <[email protected]> Co-authored-by: Matt Jibson <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note: None