ui: JavaScript Security Vulnerabilities #41538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 11, 2019 12:13
Upgrading webpack-dashboard to resolve a high severity vulnerability in handlbars Release note (admin ui change): webpack-dashboard (used in developing admin ui) upgraded
I am removing a resolution I created for axios. I don't recall if this was done in error or if new vulnerability reports have replaced old ones, but as it currently stands (https://app.snyk.io/vuln/SNYK-JS-AXIOS-472067) there is no remediation path available for this vulnerability. For the moment I am correcting our dependencies since the previous resolution left `analytics-node` without axios as a dependency potentially breaking segment analytics. By removing the resolution and upgrading to the latest stable version of `analytics-node`, I believe this is the best we can do for the moment. Release note: None
Resolving a github security alert for transient dependency on a version of lodash-es with a critial vulnerability references: - lodash/lodash#4336 - https://snyk.io/vuln/SNYK-JS-LODASH-73638 Release note: None
Bumping version of mocha to remove a dependency on `mem` which has a moderate vulnerability alerted by github Release note: None
this removes randomatic as a dependency, which had a security vulnerabilty alerted by github Release note: None
Upgrading karma to remediate a security vulnerability reported by npm audit (https://www.npmjs.com/advisories/786) Release note: None
Adding dependency upgrades to yarn-vendor Release note: None
|
This change is |
vilterp
approved these changes
Oct 11, 2019
This was referenced Oct 11, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 14, 2019
41538: ui: JavaScript Security Vulnerabilities r=nathanstilwell a=nathanstilwell Resolving vulnerabilities alerted by Github, + handlebars + mem + lodash-es + randomatic Unable to resolve a vulnerability [reported by synk](https://app.snyk.io/vuln/SNYK-JS-AXIOS-472067) as no remediation exists currently. Also unable to resolve the github alert for `webpack-dev-server` without upgrading to Weback version 4. Co-authored-by: Nathan Stilwell <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving vulnerabilities alerted by Github,
Unable to resolve a vulnerability reported by synk as no remediation exists currently. Also unable to resolve the github alert for
webpack-dev-serverwithout upgrading to Weback version 4.