release-19.2: sql: don't allocate phaseTimes on each call to sqlStatsCollector.reset #41427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allocation was responsible for **0.28%** of a CPU profile when running Sysbench's oltp_point_select workload. This was broken in ee48ea7. Release justification: Reverts perf regression due to newly introduced memory allocations. Release note: None
|
This change is |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #41374.
/cc @cockroachdb/release
This allocation was responsible for 0.28% of a CPU profile when running Sysbench's oltp_point_select workload.
This was broken in ee48ea7. @yuzefovich do you remember anything about this? The change in that commit to store
phaseTimesby reference instead of by value insqlStatsCollectorlooks very deliberate. See ee48ea7#diff-4fd6eaee39da7af19c97fbf9311f2c1fL1864-R1871.Release justification: Avoids perf regression due to newly introduced memory allocations.
Release note: None