batcheval: fix empty-span fast-path in AddSSTable collision check #41194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that the iterator has an upper-bound, it should simply be invalid after seeking past the span if empty. Release note: none. Release justification: small, low-risk fix for bug in new code that made it slower than expected.
|
This change is |
petermattis
approved these changes
Sep 30, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @danhhz and @nvanbenschoten)
nvanbenschoten
approved these changes
Sep 30, 2019
|
bors r+ |
|
TFTRs! |
craig bot
pushed a commit
that referenced
this pull request
Sep 30, 2019
41194: batcheval: fix empty-span fast-path in AddSSTable collision check r=dt a=dt Given that the iterator has an upper-bound, it should simply be invalid after seeking past the span if empty. Release note: none. Release justification: small, low-risk fix for bug in new code that made it slower than expected. Co-authored-by: David Taylor <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the iterator has an upper-bound, it should simply be invalid after seeking past the span if empty.
Release note: none.
Release justification: small, low-risk fix for bug in new code that made it slower than expected.