roachtest: add version gate for statement in schemachange/mixed/tpcc #40912
Conversation
`schemachange/mixed/tpcc` was failing on 19.1 because `CREATE TABLE AS` with a specified primary key was only added in 19.2. This PR adds a version gate in the test for that statement. Release justification: Fixes a broken test. Release note: None
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @lucy-zhang and @pbardea)
pkg/cmd/roachtest/schemachange.go, line 414 at r1 (raw file):
Extra: "--wait=false --tolerate-errors", During: func(ctx context.Context) error { if t.IsBuildVersion(`v19.2.0`) {
Do we want this to check if it is version 19.2 or later? (Rather than exactly 19.2.0?)
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/schemachange.go, line 414 at r1 (raw file):
Previously, pbardea (Paul Bardea) wrote…
Do we want this to check if it is version 19.2 or later? (Rather than exactly 19.2.0?)
This method has a misleading name. It actually checks whether the version is at least 19.2.0.
There was a problem hiding this comment.
LGTM
Reviewable status:
pkg/cmd/roachtest/schemachange.go, line 414 at r1 (raw file):
Previously, lucy-zhang (Lucy Zhang) wrote…
This method has a misleading name. It actually checks whether the version is at least
19.2.0.
Haha nice. Good to know.
|
bors r+ |
40912: roachtest: add version gate for statement in schemachange/mixed/tpcc r=lucy-zhang a=lucy-zhang `schemachange/mixed/tpcc` was failing on 19.1 because `CREATE TABLE AS` with a specified primary key was only added in 19.2. This PR adds a version gate in the test for that statement. Fixes #39622. Release justification: Fixes a broken test. Release note: None Co-authored-by: Lucy Zhang <[email protected]>
Build succeeded |
schemachange/mixed/tpccwas failing on 19.1 becauseCREATE TABLE ASwith aspecified primary key was only added in 19.2. This PR adds a version gate in
the test for that statement.
Fixes #39622.
Release justification: Fixes a broken test.
Release note: None