opt: fix memory corruption causing stack overflow #40644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug which was causing memory corruption and leading to stack overflow. The fix changes DerivePruneCols to always use a deep copy when deriving the PruneCols column set from other relational properties. Fixes cockroachdb#40589 Release note (bug fix): Fixed a memory corruption error in the optimizer that could cause stack overflow.
|
This change is |
|
Regarding merging justification during release stability period, I believe this falls under "Low risk, high benefit changes to existing functionality". |
|
TFTR! bors r+ |
Build failed (retrying...) |
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Sep 11, 2019
40644: opt: fix memory corruption causing stack overflow r=rytaft a=rytaft This commit fixes a bug which was causing memory corruption and leading to stack overflow. The fix changes `DerivePruneCols` to always use a deep copy when deriving the `PruneCols` column set from other relational properties. Fixes #40589 Release note (bug fix): Fixed a memory corruption error in the optimizer that could cause stack overflow. Co-authored-by: Rebecca Taft <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug which was causing memory corruption and leading
to stack overflow. The fix changes
DerivePruneColsto always use a deepcopy when deriving the
PruneColscolumn set from other relational properties.Fixes #40589
Release note (bug fix): Fixed a memory corruption error in the optimizer
that could cause stack overflow.