exec: minor clean up #40618
Merged
exec: minor clean up #40618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Ahh that looks better -- maybe just expand on the comment for the function to say that you don't need to check for nulls before using the function. LGTM |
yuzefovich
force-pushed
the
exec-cleanup
branch
from
847a7f1 to
d8dd02d
Compare
Previously, when converting a columnar value to a tree.Datum, we would check for nulls separately. Now this is done as part of the conversion which cleans up the code a bit. Release note: None
yuzefovich
force-pushed
the
exec-cleanup
branch
from
d8dd02d to
8c60e97
Compare
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 10, 2019
40618: exec: minor clean up r=yuzefovich a=yuzefovich Previously, when converting a columnar value to a tree.Datum, we would check for nulls separately. Now this is done as part of the conversion which cleans up the code a bit. Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when converting a columnar value to a tree.Datum, we
would check for nulls separately. Now this is done as part of the
conversion which cleans up the code a bit.
Release note: None