storage: don't use caller's context in {Maybe,Add}Async #40539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
approved these changes
Sep 6, 2019
|
TFTR bors r=nvanbenschoten |
|
bors r=nvanbenschoten |
|
bors r+ |
|
bors r+
|
|
Already running a review |
|
bors r+
…On Fri, Sep 6, 2019, 23:32 craig[bot] ***@***.***> wrote:
Already running a review
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40539?email_source=notifications&email_token=ABGXPZGZJTBATEF6YMOBPGDQILD7VA5CNFSM4IUIRKM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6EDSWQ#issuecomment-529021274>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABGXPZEQZ3O6H3ETCP3HBOLQILD7VANCNFSM4IUIRKMQ>
.
|
|
bors r+ |
The callers context often cancels immediately after the operation is enqueued, and that doesn't mean that we don't want to go ahead and queue the replica. Was seeing lots of messages about this in the logs. Release note: None
nvanbenschoten
force-pushed
the
queue-ctx
branch
from
6d089dc to
a8e1ddd
Compare
|
Rebased on master, which seemed to fix the other issue. bors r+ |
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Sep 11, 2019
40539: storage: don't use caller's context in {Maybe,Add}Async r=nvanbenschoten a=tbg
The callers context often cancels immediately after the operation is
enqueued, and that doesn't mean that we don't want to go ahead and
queue the replica.
Was seeing lots of messages about this in the logs.
Release note: None
Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callers context often cancels immediately after the operation is
enqueued, and that doesn't mean that we don't want to go ahead and
queue the replica.
Was seeing lots of messages about this in the logs.
Release note: None