roachtest: don't retry getDiskUsageInBytes if context is canceled #39810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We see 9741070 identical lines like: ``` 14:47:24]W: [Step 2/2] I190820 14:47:24.014582 176324 cluster.go:1985 failed to log message: write /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/20190820-1445527/import/tpch/nodes=8/run_1/diskusage-exec.log: no space left on device: retrying disk usage computation after spurious error: cluster.RunWithBuffer: context canceled ``` in the teamcity roachprod logs, which looks to be the cause of the error: ``` Artifact file 'diskusage-exec.log' has size 28719493120 bytes which exceeds maximum allowed size of 3221225472 bytes. Maximum artifact size is configured at the Administration -> Global Settings page. ``` This might also be related to some test timeouts. Release note: None
|
This change is |
andreimatei
reviewed
Aug 21, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 21, 2019
39810: roachtest: don't retry getDiskUsageInBytes if context is canceled r=nvanbenschoten a=nvanbenschoten We see 9741070 identical lines like: ``` 14:47:24]W: [Step 2/2] I190820 14:47:24.014582 176324 cluster.go:1985 failed to log message: write /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/20190820-1445527/import/tpch/nodes=8/run_1/diskusage-exec.log: no space left on device: retrying disk usage computation after spurious error: cluster.RunWithBuffer: context canceled ``` in the teamcity roachprod logs, which looks to be the cause of the error: ``` Artifact file 'diskusage-exec.log' has size 28719493120 bytes which exceeds maximum allowed size of 3221225472 bytes. Maximum artifact size is configured at the Administration -> Global Settings page. ``` This might also be related to some test timeouts. Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see 9741070 identical lines like:
in the teamcity roachprod logs, which looks to be the cause of the error:
This might also be related to some test timeouts.
Release note: None