storage: de-flake TestReplicateQueueDownReplicate #39630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduced via ``` make stressrace PKG=./pkg/storage/ TESTS=TestReplicateQueueDownReplicate STRESSFLAGS='-stderr=false -p 12' ``` in a few minutes (on a gceworker). The test would sometimes fail since the range log verification was overly aggressive in the sense that it would fail on all but the expected reasons. However we have learners now and sometimes they're rolled back, which also causes events. The range log checks were overly complicated to, so boil them down a bunch to something more manageable. Release note: None
|
This change is |
danhhz
approved these changes
Aug 13, 2019
|
TFTR! bors r=danhhz |
Build failed |
|
looks like the test tries to manually run EXPERIMENTAL_RELOCATE, so I could see us getting this error from there |
|
I'll look into that flake separately, but it's not an issue introduced by this deflake bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 13, 2019
39630: storage: de-flake TestReplicateQueueDownReplicate r=danhhz a=tbg Reproduced via ``` make stressrace PKG=./pkg/storage/ TESTS=TestReplicateQueueDownReplicate STRESSFLAGS='-stderr=false -p 12' ``` in a few minutes (on a gceworker). The test would sometimes fail since the range log verification was overly aggressive in the sense that it would fail on all but the expected reasons. However we have learners now and sometimes they're rolled back, which also causes events. The range log checks were overly complicated to, so boil them down a bunch to something more manageable. Release note: None Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
|
Thanks Dan
…On Tue, Aug 13, 2019, 19:31 craig[bot] ***@***.***> wrote:
Merged #39630 <#39630> into
master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39630?email_source=notifications&email_token=ABGXPZBCHUIKLQQ2GNVTMVLQELVXBA5CNFSM4ILMTRHKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTA6UISY#event-2554152011>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABGXPZBK6LPLZQPNIORJRVDQELVXBANCNFSM4ILMTRHA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduced via
in a few minutes (on a gceworker).
The test would sometimes fail since the range log verification was
overly aggressive in the sense that it would fail on all but the
expected reasons. However we have learners now and sometimes they're
rolled back, which also causes events.
The range log checks were overly complicated to, so boil them down a
bunch to something more manageable.
Release note: None