Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #39488

Merged
merged 1 commit into from
Aug 10, 2019
Merged

Update CONTRIBUTING.md #39488

merged 1 commit into from
Aug 10, 2019

Conversation

knz
Copy link
Contributor

@knz knz commented Aug 9, 2019

(the wiki links were broken/outdated)

Release note: none

@knz knz requested review from jordanlewis and kenliu August 9, 2019 15:01
@cockroach-teamcity
Copy link
Member

This change is Reviewable

(the wiki links were broken/outdated)

Release note: none
@knz knz force-pushed the 20190809-wiki-links branch from 7441e0e to 564422c Compare August 9, 2019 15:05
Copy link

@kenliu kenliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch(es)!

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis)

@knz
Copy link
Contributor Author

knz commented Aug 10, 2019

bors r+

craig bot pushed a commit that referenced this pull request Aug 10, 2019
39488: Update CONTRIBUTING.md r=knz a=knz

(the wiki links were broken/outdated)

Release note: none

Co-authored-by: Raphael 'kena' Poss <[email protected]>
@craig
Copy link
Contributor

craig bot commented Aug 10, 2019

Build succeeded

@craig craig bot merged commit 564422c into cockroachdb:master Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants