c-deps: fix assertion-enabled builds #39470
Merged
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assertion-enabled builds fell into disrepair a while ago. Neither the libroach one nor the rocksdb one worked. This PR fixes both with a few small changes. These issues were known for a while but only felt worth fixing now that we have more people who might be debugging storage engine issues. Release note: None
|
This change is |
petermattis
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @itsbilal and @petermattis)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 10, 2019
39470: c-deps: fix assertion-enabled builds r=ajkr a=ajkr The assertion-enabled builds fell into disrepair a while ago. Neither the libroach one nor the rocksdb one worked. This PR fixes both with a few small changes. These issues were known for a while but only felt worth fixing now that we have more people who might be debugging storage engine issues. Release note: None Co-authored-by: Andrew Kryczka <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertion-enabled builds fell into disrepair a while ago. Neither
the libroach one nor the rocksdb one worked. This PR fixes both with a
few small changes. These issues were known for a while but only felt
worth fixing now that we have more people who might be debugging storage
engine issues.
Release note: None