importccl: Fixes target col bug for IMPORT INTO #39455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
approved these changes
Aug 14, 2019
adityamaru27
force-pushed
the
target-col-bug
branch
from
80b0f4d
to
0772e2c
Compare
There was an edge case where if you did not specify any target columns and your target table had a PK specified, then we would fail the IMPORT because your non-target col was non-nullable. Added check that we did indeed specify at least one target before enforcing the non-nullable clause. Release note: None
adityamaru27
force-pushed
the
target-col-bug
branch
from
0772e2c
to
022f0da
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 16, 2019
39455: importccl: Fixes target col bug for IMPORT INTO r=adityamaru27 a=adityamaru27 There was an edge case where if you did not specify any target columns and your target table had a PK specified, then we would fail the IMPORT because your non-target col (PK column) was non-nullable. Added check that we did indeed specify at least one target before enforcing the non-nullable condition. Release note: None Co-authored-by: Aditya Maru <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an edge case where if you did not specify any target
columns and your target table had a PK specified, then we would
fail the IMPORT because your non-target col (PK column) was non-nullable.
Added check that we did indeed specify at least one target before
enforcing the non-nullable condition.
Release note: None