exec: bugfix to const operator #39266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, the const operator didn't properly respect selection vectors - it simply overwrote the entire column without regard for whether the selection vector touched tuples it was writing or not. This proved problematic for the case operator. Fix this and add tests. Release note: None
jordanlewis
force-pushed
the
fix-const-null
branch
from
ccb8628
to
8732651
Compare
yuzefovich
approved these changes
Aug 2, 2019
There was a problem hiding this comment.
Nice find!
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rohany)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 2, 2019
39266: exec: bugfix to const operator r=jordanlewis a=jordanlewis Previously, the const operator didn't properly respect selection vectors - it simply overwrote the entire column without regard for whether the selection vector touched tuples it was writing or not. This proved problematic for the case operator. Fix this and add tests. Release note: None Co-authored-by: Jordan Lewis <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the const operator didn't properly respect selection vectors
selection vector touched tuples it was writing or not. This proved
problematic for the case operator. Fix this and add tests.
Release note: None