-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove admin privilege for force_retry #39243 #39246
Conversation
Thanks! There's also a test for this error that needs to be removed (in |
@bdarnell you're welcome! |
bors r+ |
Build succeeded |
@bdarnell, this hasn't changed in our auto-generated functions doc. Still shows up as |
Yeah, 'system info functions' is still the right place for it. Nothing needs to change because the admin privilege was removed, but now that we're using this in our examples we should probably give it some actual docs instead of "internal use only". |
Also, delete the comments in the Python code that state that `crdb_internal.force_retry()` must be run as root. This restriction was lifted in cockroachdb/cockroach#39246. The 19.1 Python code samples were updated in #5085 and #5173. We then forgot to port those changes to 19.2. This commit remedies that oversight. Addresses part of #5176.
Also, delete the comments in the Python code that state that `crdb_internal.force_retry()` must be run as root. This restriction was lifted in cockroachdb/cockroach#39246. The 19.1 Python code samples were updated in #5085 and #5173. We then forgot to port those changes to 19.2. This commit remedies that oversight. Addresses part of #5176.
Resolves #39243