parser: Adds new grammar to support user specified PK in CTAS query. #38884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
Reviewed 2 of 4 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dt)
|
bors r+ |
Build failed |
adityamaru27
force-pushed
the
grammer-change-for-pk
branch
from
73056be to
7d77555
Compare
This change adds grammar rules to support users specifying the primary key columns in a CREATE TABLE...AS query. It is a subset of the grammar which is used by a normal CREATE TABLE query, without having to specify the types for each of the columns in the new table. Release note: sql change
adityamaru27
force-pushed
the
grammer-change-for-pk
branch
from
7d77555 to
3fd121a
Compare
|
Merged as part of #38589. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds grammar rules to support users specifying the
primary key columns in a
CREATE TABLE...ASquery. It allows for both column level qualification, as well as constraint style declaration of PKs.eg:
CREATE TABLE a (id PRIMARY KEY) AS SELECT * FROM bCREATE TABLE a (id, PRIMARY KEY(id)) AS SELECT * FROM bCREATE TABLE a (id, idtwo, PRIMARY KEY(id, idtwo)) AS SELECT * FROM bDue to
CREATE TABLEandCREATE TABLE ... AShaving an identical syntax for declaring PKs, the logic resolving qualifiers and/or constraints had to be pushed to after acolumn_namewithout a type is encountered. This avoids reduce/reduce conflicts, but introduces a restriction that aPRIMARY KEYconstraint must be preceded by at least one column name.Release note: sql change