build: adding missing bin/.bootstrap order-only dependency #38857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any rule which uses `gofmt` or `goimports` needs to have an order-only dependency on `bin/.bootstrap`, otherwise the `bin/.bootstrap` rule can run in parallel causing a race between `bin/gofmt` getting created and it being used by the rule. This would result in rare "text file busy" errors when running a partially written `bin/gofmt`. Release note: None
|
This change is |
|
Cc @andreimatei, @tbg |
|
@bobvawter Do you know make well enough to review this? |
bobvawter
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
I'll pretend that I know more about make than I ought to :-) . I assume that you've grepped for all rules that invoke gofmt and tweaked them?
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
petermattis
commented
Jul 15, 2019
There was a problem hiding this comment.
I assume that you've grepped for all rules that invoke gofmt and tweaked them?
Yep. And goimports as well.
Reviewable status:
|
TFTR! Unrelated roachtest failure. bors r=bobvawter |
craig bot
pushed a commit
that referenced
this pull request
Jul 15, 2019
38857: build: adding missing bin/.bootstrap order-only dependency r=bobvawter a=petermattis Any rule which uses `gofmt` or `goimports` needs to have an order-only dependency on `bin/.bootstrap`, otherwise the `bin/.bootstrap` rule can run in parallel causing a race between `bin/gofmt` getting created and it being used by the rule. This would result in rare "text file busy" errors when running a partially written `bin/gofmt`. Release note: None Co-authored-by: Peter Mattis <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any rule which uses
gofmtorgoimportsneeds to have an order-onlydependency on
bin/.bootstrap, otherwise thebin/.bootstraprule canrun in parallel causing a race between
bin/gofmtgetting created andit being used by the rule. This would result in rare "text file busy"
errors when running a partially written
bin/gofmt.Release note: None