roachpb: make AdminChangeReplicasRequest.ExpDesc non-nullable #38843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Prior to 19.1 AdminChangeReplicas did not take an expected range descriptor value which allowed for races with other changes to the range descriptor. For backwards compatibility the expectation was left as an optional field. This commit completes the migration and makes ExpDesc a required, non-nullable field. Clients which supply a zero value ExpDesc will now receive an error. Release note: None
ajwerner
force-pushed
the
ajwerner/make-exp-desc-required-in-change-replicas
branch
from
196abc9 to
0a33dca
Compare
nvanbenschoten
approved these changes
Jul 12, 2019
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 12, 2019
38843: roachpb: make AdminChangeReplicasRequest.ExpDesc non-nullable r=ajwerner a=ajwerner Prior to 19.1 AdminChangeReplicas did not take an expected range descriptor value which allowed for races with other changes to the range descriptor. For backwards compatibility the expectation was left as an optional field. This commit completes the migration and makes ExpDesc a required, non-nullable field. Clients which supply a zero value ExpDesc will now receive an error. Relates to #36025. Release note: None Co-authored-by: Andrew Werner <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to 19.1 AdminChangeReplicas did not take an expected range descriptor
value which allowed for races with other changes to the range descriptor. For
backwards compatibility the expectation was left as an optional field. This
commit completes the migration and makes ExpDesc a required, non-nullable
field. Clients which supply a zero value ExpDesc will now receive an error.
Relates to #36025.
Release note: None