exec: Fix bug in test case generation causing NULLs not to be reset between batches #38612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
approved these changes
Jul 2, 2019
There was a problem hiding this comment.
Nice find, thanks!
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rohany and @solongordon)
pkg/sql/exec/utils_test.go, line 269 at r1 (raw file):
} // Reset nulls for all columns in this batch
[nit]: missing period.
pkg/sql/exec/utils_test.go, line 349 at r1 (raw file):
} // Reset nulls for all columns in this batch
ditto
There was a small bug in the exec test generator causing some nulls in batches to not be reset, due to iterating over the columns of the input tuple type rather than over all columns in the batch. Release note: None
|
TFTR! Fixed that up. |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 2, 2019
38612: exec: Fix bug in test case generation causing NULLs not to be reset between batches r=rohany a=rohany There was a small bug in the exec test generator causing some nulls in batches to not be reset, due to iterating over the columns of the input tuple type rather than over all columns in the batch. Release note: None Co-authored-by: Rohan Yadav <[email protected]>
solongordon
reviewed
Jul 2, 2019
There was a problem hiding this comment.
I wonder if it would be better to make a new batch every time Next() is called. That way we don't need to worry about the batch being mutated by downstream operators, e.g. setting nulls or adding more columns.
Reviewable status:
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small bug in the exec test generator causing some
nulls in batches to not be reset, due to iterating over the
columns of the input tuple type rather than over all columns
in the batch.
Release note: None