Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/quotapool: various features and fixes #38587

Merged
merged 3 commits into from
Jul 9, 2019

Conversation

ajwerner
Copy link
Contributor

@ajwerner ajwerner commented Jul 1, 2019

This code is being pulled from ongoing work on admission control but this
change seemed isolated enough to warrant a separate PR.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ajwerner ajwerner force-pushed the ajwerner/quotapool-len branch from d3b052f to 3855f91 Compare July 1, 2019 19:48
@ajwerner ajwerner changed the title util/quotapool: add Len() method to return the current queue length util/quotapool: various features and fixes Jul 1, 2019
@ajwerner ajwerner requested a review from andreimatei July 1, 2019 20:40
ajwerner added 3 commits July 2, 2019 18:12
This code is being pulled from ongoing work on admission control but this
change seemed isolated enough to warrant a separate PR.

Release note: None
This change is used in upcoming work on admission control but felt sufficiently
isolated to warrant its own PR. This function is especially useful for
recording metrics after an acquisition has occurred.

Release note: None
@ajwerner ajwerner force-pushed the ajwerner/quotapool-len branch from 6d0662f to 8dcbaa3 Compare July 2, 2019 22:12
Copy link
Contributor

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)

@ajwerner
Copy link
Contributor Author

ajwerner commented Jul 9, 2019

bors r+

craig bot pushed a commit that referenced this pull request Jul 9, 2019
38587: util/quotapool: various features and fixes r=ajwerner a=ajwerner

This code is being pulled from ongoing work on admission control but this
change seemed isolated enough to warrant a separate PR.

Release note: None

Co-authored-by: Andrew Werner <[email protected]>
@craig
Copy link
Contributor

craig bot commented Jul 9, 2019

Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants