importccl: ignore query params when detecting file compression from suffix #38521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uffix This changes the detection of the compression scheme to, if it does not find the suffix it is looking for, run again after parsing the filename as a URI and only using the Path component. Release note (sql change): enable automatic detection of compression schemes on filenames in IMPORT that have parameters after the path.
|
This change is |
thoszhang
approved these changes
Jun 27, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 28, 2019
38521: importccl: ignore query params when detecting file compression from suffix r=dt a=dt This changes the detection of the compression scheme to, if it does not find the suffix it is looking for, run again after parsing the filename as a URI and only using the Path component. Fixes #32100. Release note (sql change): enable automatic detection of compression schemes on filenames in IMPORT that have parameters after the path. Co-authored-by: David Taylor <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the detection of the compression scheme to, if it does not find the suffix it is looking for, run again after parsing the filename as a URI and only using the Path component.
Fixes #32100.
Release note (sql change): enable automatic detection of compression schemes on filenames in IMPORT that have parameters after the path.