Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: fix swallowing Unsplit error #38433

Merged
merged 1 commit into from
Jun 26, 2019
Merged

sql: fix swallowing Unsplit error #38433

merged 1 commit into from
Jun 26, 2019

Conversation

jeffrey-xiao
Copy link
Contributor

Realized this condition should be negated.

Fixes #38131, #38095.

Release note: None

@jeffrey-xiao jeffrey-xiao requested review from a team June 26, 2019 14:21
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jeffrey-xiao
sql: fix swallowing Unsplit error
922f297 
The condition for checking if the range has already been unsplit should
be negated.

Release note: None
@jeffrey-xiao
Copy link
Contributor Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 26, 2019

Build failed

@jeffrey-xiao
Copy link
Contributor Author

jeffrey-xiao commented Jun 26, 2019 •
edited
Loading

Seems to be a TeamCity flake: `

Unexpected error: java.lang.RuntimeException: Failed to create context for build runner: Error creating bean with name 'jetbrains.buildServer.agent.impl.buildStages.startStages.steps.StepExecutor#0'

bors r+

craig bot pushed a commit that referenced this pull request Jun 26, 2019
@jeffrey-xiao
Merge #38433
c836e59 
38433: sql: fix swallowing Unsplit error r=jeffrey-xiao a=jeffrey-xiao

Realized this condition should be negated.

Fixes #38131, #38095.

Release note: None

Co-authored-by: Jeffrey Xiao <[email protected]>
@craig
Copy link
Contributor

craig bot commented Jun 26, 2019

Build succeeded

@craig craig bot merged commit 922f297 into cockroachdb:master Jun 26, 2019
@jeffrey-xiao jeffrey-xiao deleted the fix-truncate branch August 15, 2019 17:48
@knz knz mentioned this pull request Nov 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvanbenschoten nvanbenschoten nvanbenschoten approved these changes

@ajwerner ajwerner Awaiting requested review from ajwerner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

roachtest: clearrange/checks=true failed
3 participants
@jeffrey-xiao @cockroach-teamcity @nvanbenschoten