sql: special case lowercase "utc" as alias to "UTC". #38195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This patch is a crutch to support the special case of `"utc"` by popular demand. For more details and guidance towards a better solution, see issue cockroachdb#36864. Release note (sql change): CockroachDB now supports the special case `set timezone = 'utc'` as a special alias for `set timezone = 'UTC'`. The other time zone names are still case-sensitive as previously, pending resolution of issue cockroachdb#36864.
jordanlewis
approved these changes
Jun 17, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @bdarnell and @jordanlewis)
|
tfyr @jordanlewis please take over the backport if you think that's useful. bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 17, 2019
38195: sql: special case lowercase "utc" as alias to "UTC". r=knz a=knz Informs #36864. Informs (and perhaps closes) #14988. This patch is a crutch to support the special case of `"utc"` by popular demand. For more details and guidance towards a better solution, see issue #36864. Release note (sql change): CockroachDB now supports the special case `set timezone = 'utc'` as a special alias for `set timezone = 'UTC'`. The other time zone names are still case-sensitive as previously, pending resolution of issue #36864. Co-authored-by: Raphael 'kena' Poss <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #36864.
Informs (and perhaps closes) #14988.
This patch is a crutch to support the special case of
"utc"bypopular demand. For more details and guidance towards a better
solution, see issue #36864.
Release note (sql change): CockroachDB now supports the special case
set timezone = 'utc'as a special alias forset timezone = 'UTC'. The other time zone names are still case-sensitive aspreviously, pending resolution of issue #36864.