sql: Address inet casting roundtrip issue #37938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
solongordon
approved these changes
May 30, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @solongordon)
|
no, the issue with the values command still remains, this fixes jordan's comment in the issues. |
Fixes an issue brought up in cockroachdb#37938, but does not resolve the entire issue. Release note (sql change): Fix a roundtrip typecasting issue where an inet casted to a string and back to an inet would fail.
|
bors r+ |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 3, 2019
37938: sql: Address inet casting roundtrip issue r=rohany a=rohany Address a small issue brought up in #32876, where conversion of an inet into a string, and back into an inet would fail. Co-authored-by: Rohan Yadav <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address a small issue brought up in #32876, where conversion of an inet into a string, and back into an inet would fail.