storage/txnrecovery: add transaction recovery metrics #37807
Conversation
|
This change is |
This commit adds a series of time series metrics that provide insight into the process of transaction recovery due to abandoned parallel commits. New metrics: - `txnrecovery.attempts.pending` - `txnrecovery.attempts.total` - `txnrecovery.successes.committed` - `txnrecovery.successes.aborted` - `txnrecovery.successes.pending` - `txnrecovery.failures` Release note: None
The function used to contain more logic, but now it just defers to IsParallelCommit, so there's no point in keeping it. Release note: None
nvanbenschoten
force-pushed
the
nvanbenschoten/txnRecoveryMetrics
branch
from
1d2a776
to
c5a760a
Compare
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained
pkg/storage/txnrecovery/manager_test.go, line 53 at r1 (raw file):
} type metricVals struct {
This pattern is handy but verbose. It’d be nice to automate the generation of these from a metrics struct. Could be a good little Friday project.
There was a problem hiding this comment.
bors r+
Reviewable status:
pkg/storage/txnrecovery/manager_test.go, line 53 at r1 (raw file):
Previously, ajwerner wrote…
This pattern is handy but verbose. It’d be nice to automate the generation of these from a metrics struct. Could be a good little Friday project.
Yeah, this seems like a cool idea. Code gen might be a bit of a big hammer though. I bet we could do something a little more lightweight with reflection and a map[string]int64. Let's keep this in mind for the next time we turn to this pattern.
37807: storage/txnrecovery: add transaction recovery metrics r=nvanbenschoten a=nvanbenschoten This commit adds a series of time series metrics that provide insight into the process of transaction recovery due to abandoned parallel commits. New metrics: - `txnrecovery.attempts.pending` - `txnrecovery.attempts.total` - `txnrecovery.successes.committed` - `txnrecovery.successes.aborted` - `txnrecovery.successes.pending` - `txnrecovery.failures` Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]>
Build succeeded |
This commit adds a series of time series metrics that provide insight
into the process of transaction recovery due to abandoned parallel
commits.
New metrics:
txnrecovery.attempts.pendingtxnrecovery.attempts.totaltxnrecovery.successes.committedtxnrecovery.successes.abortedtxnrecovery.successes.pendingtxnrecovery.failuresRelease note: None