rpc: add heartbeat metrics #37361
rpc: add heartbeat metrics #37361
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ajwerner and @DuskEagle)
pkg/rpc/context.go, line 398 at r1 (raw file):
version *cluster.ExposedClusterVersion metrics Metrics
Missing import for this?
ajwerner
force-pushed
the
ajwerner/rpc-metrics
branch
2 times, most recently
from
2ad25fd
to
5d8a5cc
Compare
There was a problem hiding this comment.
Thanks for the quick review. I had forgotten to add an entire file. RFAL.
Reviewable status:
pkg/rpc/context.go, line 398 at r1 (raw file):
Previously, DuskEagle (Joel Kenny) wrote…
Missing import for this?
Forgot to git add a whole file
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 2 of 2 files at r2.
Reviewable status:
a discussion (no related file):
pkg/rpc/metrics.go, line 113 at r2 (raw file):
// updateHeartbeatState increments the gauge for the current state and // decrements the gauge for the new state, returning the new state.
This comment is backward, it should be something likedecrements the gauge for the old state.
ajwerner
force-pushed
the
ajwerner/rpc-metrics
branch
from
5d8a5cc
to
5d890d0
Compare
There was a problem hiding this comment.
Reviewable status:
a discussion (no related file):
Previously, DuskEagle (Joel Kenny) wrote…
:lgtm: Aside from the one comment.
TFTR!
pkg/rpc/metrics.go, line 113 at r2 (raw file):
Previously, DuskEagle (Joel Kenny) wrote…
This comment is backward, it should be something like
decrements the gauge for the old state.
Done.
ajwerner
force-pushed
the
ajwerner/rpc-metrics
branch
2 times, most recently
from
dfaaa42
to
7ddb91c
Compare
This PR adds metrics to the rpc context. The initial set of metrics includes gauges to track the current state of heartbeat loops as well as counters for the number of loops started and failed. The gauges give a nice point-in-time view of the state of a server's connections but are subject to aliasing while the counters fail to capture how many of the connections are actually observing problems. Taken together they ought to provide some insight into the state of network health between nodes. Release note: None
ajwerner
force-pushed
the
ajwerner/rpc-metrics
branch
from
7ddb91c
to
4850713
Compare
|
bors r+ |
37361: rpc: add heartbeat metrics r=ajwerner a=ajwerner This PR adds metrics to the rpc context. The initial set of metrics includes gauges to track the current state of heartbeat loops as well as counters for the number of loops started and failed. The gauges give a nice point-in-time view of the state of a server's connections but are subject to aliasing while the counters fail to capture how many of the connections are actually observing problems. Taken together they ought to provide some insight into the state of network health between nodes. Release note: None Co-authored-by: Andrew Werner <[email protected]>
Build succeeded |
This PR adds metrics to the rpc context. The initial set of metrics includes
gauges to track the current state of heartbeat loops as well as counters for
the number of loops started and failed. The gauges give a nice point-in-time
view of the state of a server's connections but are subject to aliasing while
the counters fail to capture how many of the connections are actually observing
problems. Taken together they ought to provide some insight into the state of
network health between nodes.
Release note: None