sql: fix window functions with GROUPS offset FOLLOWING #37222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, boundaries of peer groups were incorrectly determined with GROUPS BETWEEN offset FOLLOWING AND UNBOUNDED FOLLOWING mode of framing due to an incorrect special case (I don't know what I was thinking when I wrote that) that didn't confirm to the contract of the methods. Release note: None
|
This change is |
jordanlewis
reviewed
Apr 30, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)
yuzefovich
commented
Apr 30, 2019
There was a problem hiding this comment.
No, that was a special case only for GROUPS BETWEEN offset FOLLOWING AND UNBOUNDED FOLLOWING, the PRECEDING case doesn't have special handling (since the general logic handles it), so it should behave correctly (I've just confirmed it locally with a few cases, and it returned nulls as expected for empty frames).
TFTR!
bors r+
Reviewable status:
craig bot
pushed a commit
that referenced
this pull request
Apr 30, 2019
37222: sql: fix window functions with GROUPS offset FOLLOWING r=yuzefovich a=yuzefovich Previously, boundaries of peer groups were incorrectly determined with GROUPS BETWEEN offset FOLLOWING AND UNBOUNDED FOLLOWING mode of framing due to an incorrect special case (I don't know what I was thinking when I wrote that) that didn't confirm to the contract of the methods. Fixes: #37201. Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, boundaries of peer groups were incorrectly determined
with GROUPS BETWEEN offset FOLLOWING AND UNBOUNDED FOLLOWING mode
of framing due to an incorrect special case (I don't know what I
was thinking when I wrote that) that didn't confirm to the contract
of the methods.
Fixes: #37201.
Release note: None