roachtest: Shrink scrub workloads #37046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scrub roachtest was previously running tpcc-1000 on a cluster of 12 total vcpus, which is not enough (it needs ~double that). This exposed a lot of interesting issues like cockroachdb#35986, but it's only incidental to the main purpose of this test (and it's also flaky due to uninteresting problems associated with overloading). Switch the test to tpcc-100 so it can be stable; we'll reintroduce a test dedicated to overload conditions in the future (when we can make it stable). Fixes cockroachdb#35985 Fixes cockroachdb#37017 Release note: None
|
This change is |
thoszhang
approved these changes
Apr 23, 2019
|
bors r=lucy-zhang |
Build failed |
|
bors r=lucy-zhang Flaked on #36812 |
craig bot
pushed a commit
that referenced
this pull request
Apr 23, 2019
37046: roachtest: Shrink scrub workloads r=lucy-zhang a=bdarnell The scrub roachtest was previously running tpcc-1000 on a cluster of 12 total vcpus, which is not enough (it needs ~double that). This exposed a lot of interesting issues like #35986, but it's only incidental to the main purpose of this test (and it's also flaky due to uninteresting problems associated with overloading). Switch the test to tpcc-100 so it can be stable; we'll reintroduce a test dedicated to overload conditions in the future (when we can make it stable). Fixes #35985 Fixes #37017 Release note: None Co-authored-by: Ben Darnell <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scrub roachtest was previously running tpcc-1000 on a cluster of
12 total vcpus, which is not enough (it needs ~double that). This
exposed a lot of interesting issues like #35986, but it's only
incidental to the main purpose of this test (and it's also flaky due
to uninteresting problems associated with overloading).
Switch the test to tpcc-100 so it can be stable; we'll reintroduce a
test dedicated to overload conditions in the future (when we can make
it stable).
Fixes #35985
Fixes #37017
Release note: None