roachtest: don't stop nodes at end of tpc{c,h}bench #36329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#36022. Release note: None
Fixes cockroachdb#36325. Touches cockroachdb#36277. Touches cockroachdb#32135. Release note: None
|
This change is |
andreimatei
reviewed
Mar 29, 2019
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)
nvanbenschoten
approved these changes
Mar 29, 2019
|
bors r=andreimatei,nvanbenschoten |
craig bot
pushed a commit
that referenced
this pull request
Mar 29, 2019
36328: storage: skip TestStoreRangeRemoveDead, TestLeaseNotUsedAfterRestart r=andreimatei,nvanbenschoten a=tbg
We need to investigate both (in particular the former), but for now
minimize disruption.
Release note: None
36329: roachtest: don't stop nodes at end of tpc{c,h}bench r=andreimatei,nvanbenschoten a=tbg
Fixes #36325.
Touches #36277.
Touches #32135.
Fixes #36022.
Release note: None
Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36325.
Touches #36277.
Touches #32135.
Fixes #36022.
Release note: None