release-19.1: roachpb: refine Transaction proto cloning #36114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that it was easy enough to disallow interior mutability entirely within a Transaction and treat all of its references as immutable. Doing so allows us to only ever need to perform shallow clones of Transaction objects reducing the cost of a clone to a single, fixed-size allocation. Release note: None
Now that Transaction.Clone doesn't perform any deep copying, it can serve the role it should have had of simply cloning a Transaction to a new object on the heap. Callers who only need a value can use Transaction's full value semantics directly and simply copy it by value. Release note: None
|
This change is |
|
Lgtm
…On Mon, Mar 25, 2019, 20:45 cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/36114>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#36114 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE135Gaoa30KRk1hckdKHYQfj-gAyN2Rks5vaSdKgaJpZM4cIwPq>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #35762.
/cc @cockroachdb/release
Fixes #35803.
This PR includes the final two commits from #35719.
cc. @tbg