sql: avoid wrapping the special lease expiration error object #36011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue cockroachdb#35854 notwithstanding, I misunderstood the logic and considered a "perfectly normal" case to be an internal error, which was wrong. This was causing long DDL txns to abort due to lease expirations, that they would not renew. Release note: None
|
This change is |
andreimatei
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)
|
TFYR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Mar 20, 2019
36011: sql: avoid wrapping the special lease expiration error object r=knz a=knz Fixes #35734. Issue #35854 notwithstanding, I misunderstood the logic and considered a "perfectly normal" case to be an internal error, which was wrong. This was causing long DDL txns to abort due to lease expirations, that they would not renew. Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35734.
Issue #35854 notwithstanding, I misunderstood the logic and considered
a "perfectly normal" case to be an internal error, which was
wrong. This was causing long DDL txns to abort due to lease
expirations, that they would not renew.
Release note: None