sqltelemetry: make SQL telemetry more uniform, w/ linter #35647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This patch groups the telemetry counters for the SQL layer into a single package `sqltelemetry`. The package aims to document the telemetry counter in a way that's easily understandable / discoverable without having to read code. This also introduces the pattern required by @dt: that telemetry counter names generated dynamically to be generated in a way that's regular, subject to later formalization via a new API `telemetry.GetCounterf()` (so that we can automate the inventorization of all telemetry counters). This patch ensures that all the dynamic counter names go to `GetCounter(fmt.Sprintf(...))`, which we'll be able to re-structure at a later point. Finally it introduces the prefix `sql.plan`, in anticipation of a further split between `sql.parse`, `sql.plan`, `sql.exec`. Release note: None
knz
force-pushed
the
20190312-extra-telemetry
branch
from
5497249 to
df6bba0
Compare
maddyblue
approved these changes
Mar 12, 2019
|
thank you! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Mar 12, 2019
35517: build: Upgrade base image for deployment dockerfile r=mberhault a=bdarnell Debian 8.x has unpatched security vulnerabilities in the glibc package (even though it's supposed to be in its LTS period?), so upgrade to the current 9.x. https://security-tracker.debian.org/tracker/source-package/glibc Release note (build change): Release Docker images are now built on Debian 9.8. 35647: sqltelemetry: make SQL telemetry more uniform, w/ linter r=knz a=knz This patch groups the telemetry counters for the SQL layer into a single package `sqltelemetry`. The package aims to document the telemetry counter in a way that's easily understandable / discoverable without having to read code. This also introduces the pattern required by @dt: that telemetry counter names generated dynamically to be generated in a way that's regular, subject to later formalization via a new API `telemetry.GetCounterf()` (so that we can automate the inventorization of all telemetry counters). This patch ensures that all the dynamic counter names go to `GetCounter(fmt.Sprintf(...))`, which we'll be able to re-structure at a later point. Finally it introduces the prefix `sql.plan`, in anticipation of a further split between `sql.parse`, `sql.plan`, `sql.exec`. Release note: None 35656: sql: add telemetry for SERIAL expansions r=knz a=knz First commit from #35647. Informs https://github.com/cockroachlabs/registration/issues/203 This adds telemetry for the SERIAL expansion strategies. Counter format: `sql.schema.serial.<normtype>.<coltype>` For example: `sql.schema.serial.rowid.SERIAL2` Release note (sql change): CockroachDB will now report how the SERIAL pseudo-type is expanded in table column definitions, when telemetry is enabled. Co-authored-by: Ben Darnell <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch groups the telemetry counters for the SQL layer into a
single package
sqltelemetry. The package aims to document thetelemetry counter in a way that's easily understandable / discoverable
without having to read code.
This also introduces the pattern required by @dt: that telemetry
counter names generated dynamically to be generated in a way that's
regular, subject to later formalization via a new API
telemetry.GetCounterf()(so that we can automate the inventorizationof all telemetry counters). This patch ensures that all the dynamic
counter names go to
GetCounter(fmt.Sprintf(...)), which we'll beable to re-structure at a later point.
Finally it introduces the prefix
sql.plan, in anticipation of afurther split between
sql.parse,sql.plan,sql.exec.Release note: None