Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workload: run all TPC-H queries by default #35563

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

yuzefovich
Copy link
Member

Previously, we supported only a subset of 22 TPC-H queries, so by
default only that subset was run. Now, we support all of them, so
we should similarly run all of them by default.

Addresses: #35392.

Release note: None

Previously, we supported only a subset of 22 TPC-H queries, so by
default only that subset was run. Now, we support all of them, so
we should similarly run all of them by default.

Release note: None
@yuzefovich yuzefovich requested review from jordanlewis and danhhz March 9, 2019 01:31
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jordanlewis
Copy link
Member

LGTM

@awoods187 awoods187 mentioned this pull request Mar 11, 2019
8 tasks
@yuzefovich
Copy link
Member Author

TFTRs!

bors r+

@yuzefovich
Copy link
Member Author

The build crashed and seems to be stuck. Let's give it another shot.

bors r+

craig bot pushed a commit that referenced this pull request Mar 12, 2019
35563: workload: run all TPC-H queries by default r=yuzefovich a=yuzefovich

Previously, we supported only a subset of 22 TPC-H queries, so by
default only that subset was run. Now, we support all of them, so
we should similarly run all of them by default.

Addresses: #35392. 

Release note: None

Co-authored-by: Yahor Yuzefovich <[email protected]>
@craig
Copy link
Contributor

craig bot commented Mar 12, 2019

Build succeeded

@craig craig bot merged commit 135d3ad into cockroachdb:master Mar 12, 2019
@yuzefovich yuzefovich deleted the fix_tpch branch April 17, 2019 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants