sql: Fix TPCH workload #35533
Merged
sql: Fix TPCH workload #35533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde and @yuzefovich)
yuzefovich
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
Reviewable status:
Fix a couple problems in the TPCH workload: 1. Use r_name = 'EUROPE' in Q2 to match the TPCH spec sample values 2. Add ::float cast in Q11 because CRDB does not implicitly cast when multiplying float and int. Fixes cockroachdb#35418 Release note: None
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Mar 9, 2019
35533: sql: Fix TPCH workload r=andy-kimball a=andy-kimball Fix a couple problems in the TPCH workload: 1. Use r_name = 'EUROPE' in Q2 to match the TPCH spec sample values 2. Add ::float cast in Q11 because CRDB does not implicitly cast when multiplying float and int. Fixes #35418 Release note: None Co-authored-by: Andrew Kimball <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple problems in the TPCH workload:
multiplying float and int.
Fixes #35418
Release note: None