workload: use workload split functionality with tpcc #35511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
danhhz
approved these changes
Mar 7, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @ajwerner and @danhhz)
pkg/workload/tpcc/tpcc.go, line 333 at r1 (raw file):
} const warehousesPerRange = 10
I have a weak preference for sticking all these constants next to the numXPerY in generate.go
ajwerner
force-pushed
the
ajwerner/splits-with-tpcc
branch
from
2ca56cb to
b52153d
Compare
ajwerner
commented
Mar 7, 2019
There was a problem hiding this comment.
Reviewable status:
pkg/workload/tpcc/tpcc.go, line 333 at r1 (raw file):
Previously, danhhz (Daniel Harrison) wrote…
I have a weak preference for sticking all these constants next to the numXPerY in generate.go
Done.
Before this PR the tpcc workloads dealt with splitting ranges on their own. This splitting logic lacked the sophistication built in to the workload package split implementation which works to mitigate imbalance. Fixes cockroachdb#25872. Release note: None
ajwerner
force-pushed
the
ajwerner/splits-with-tpcc
branch
from
b52153d to
334a88f
Compare
|
bors r+ |
Merge conflict (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Mar 7, 2019
35511: workload: use workload split functionality with tpcc r=ajwerner a=ajwerner Before this PR the tpcc workloads dealt with splitting ranges on their own. This splitting logic lacked the sophistication built in to the workload package split implementation which works to mitigate imbalance. Fixes #25872. Release note: None 35512: c-deps: bump rocksdb for bottommost files bug fix r=ajkr a=ajkr Pick up cockroachdb/rocksdb#26 Release note: None 35519: sql: fix a non-deterministic test r=knz a=knz Release note: None 35520: build: Fix docker link for alpha/beta builds r=knz a=bdarnell Release note: None Co-authored-by: Andrew Werner <[email protected]> Co-authored-by: Andrew Kryczka <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Ben Darnell <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR the tpcc workloads dealt with splitting ranges on their own.
This splitting logic lacked the sophistication built in to the workload package
split implementation which works to mitigate imbalance.
Fixes #25872.
Release note: None