release-2.0: rpc: adopt logging in circuitbreaker #35361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
bdarnell
approved these changes
Mar 4, 2019
andreimatei
reviewed
Mar 4, 2019
There was a problem hiding this comment.
Is our copy of the circuitbreaker package pretty much identical to the dependency you're removing here?
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
It's a fork of that library. We've fixed some bugs and added more logging. I think we're about 4 commits ahead of the old dependency which seems to be abandoned. |
|
LGTM |
ajwerner
force-pushed
the
backport2.0-33676
branch
2 times, most recently
from
a7519e3 to
747876e
Compare
Adopts changes to the circuitbreaker package to enable logging. Release note: None
ajwerner
force-pushed
the
backport2.0-33676
branch
from
747876e to
1e995af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #33676.
/cc @cockroachdb/release
Adopts changes to the circuitbreaker package to enable logging.
Release note: None