storage: better error when stores are throttled #35308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
force-pushed
the
fix/throttle-better-error
branch
from
ebd16e8 to
44a9481
Compare
petermattis
approved these changes
Mar 4, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @tbg)
pkg/storage/store_snapshot.go, line 755 at r1 (raw file):
} err := &benignError{errors.Errorf("%s: remote declined %s: %s", to, snap, declinedMsg)} storePool.throttle(throttleDeclined, declinedMsg, to.StoreID)
Seems like you can generate the err after the call to storePool.throttle in which case you can return &benignError{...}. On the other hand, perhaps you mean to pass in err.Error() here as you do below.
This is an annoying blocker during replication, and has also played a role in test flakes such as cockroachdb#35307. Release note: None
tbg
force-pushed
the
fix/throttle-better-error
branch
from
44a9481 to
2beec4e
Compare
|
Done, TFTR! bors r=petermattis |
craig bot
pushed a commit
that referenced
this pull request
Mar 5, 2019
35308: storage: better error when stores are throttled r=petermattis a=tbg This is an annoying blocker during replication, and has also played a role in test flakes such as #35307. Release note: None Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an annoying blocker during replication, and has also played a
role in test flakes such as #35307.
Release note: None