-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workload: check that TPCH workload returns expected results #34891
Conversation
Some concerns are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's get this merged, although we won't currently pass.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @yuzefovich)
pkg/workload/tpch/tpch.go, line 56 at r1 (raw file):
} // TODO(yuzefovich): this seems to not be used anywhere, should we delete it?
init functions get automatically run by Go.
75afd29
to
989f97a
Compare
989f97a
to
901291b
Compare
Now, by default, whenever TPCH workload is being run, the returned output is checked against the expected results (which have been roughly confirmed with PostgreSQL). This behavior can be disabled with a flag `--disable-checks=true` to the workload command. Release note: None
901291b
to
d0511fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Query 11 has since been fixed, but it returns 1048 rows, so I added a check only for the number of rows returned for it (same as query 16).
Query 12 is still skipped (I'm not sure what the problem is, running query through cli gives the expected result, but via a workload it for some reason returns ASCII encoding of the output Error: wrong result on query 12 in row 0 in column 1: got "[54 50 48 50]", expected "6202"
).
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @jordanlewis)
pkg/workload/tpch/tpch.go, line 56 at r1 (raw file):
Previously, jordanlewis (Jordan Lewis) wrote…
init functions get automatically run by Go.
Yeah, I didn't know about this at the time, thanks!
TFTR! bors r+ |
34891: workload: check that TPCH workload returns expected results r=yuzefovich a=yuzefovich Now, by default, whenever TPCH workload is being run on scale factor of 1, the returned output is checked against the expected results (which have been roughly confirmed with PostgreSQL). This behavior can be disabled with a flag `--disable-checks=true` to the workload command. Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]>
Build succeeded |
Now, by default, whenever TPCH workload is being run on scale factor of 1,
the returned output is checked against the expected results (which have been
roughly confirmed with PostgreSQL). This behavior can be disabled
with a flag
--disable-checks=true
to the workload command.Release note: None