storage: revert a test to starting with a single range #33486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears to be a bit flaky otherwise. Release note: None
|
This change is |
|
Do you know why it's flaky? |
|
this is the NPE, right? Please add what we've found to the commit and, even better, to the line that makes the test use a single range. |
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Jan 9, 2019
This took me longer to track down than I'm comfortable admitting. The test wasn't properly checking for full upreplication because it was only looking at the first range. It still is, but that's now all the ranges -- it's finicky to upgrade the check. Fixes cockroachdb#33497. Closes cockroachdb#33486. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jan 9, 2019
33584: storage: deflake TestStoreRangeRemoveDead r=andreimatei a=tbg This took me longer to track down than I'm comfortable admitting. The test wasn't properly checking for full upreplication because it was only looking at the first range. It still is, but that's now all the ranges -- it's finicky to upgrade the check. Fixes #33497. Closes #33486. Release note: None Co-authored-by: Tobias Schottdorf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears to be a bit flaky otherwise.
Release note: None