c-deps: bump RocksDB from 5.13 to 5.17.2 #32931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
benesch
approved these changes
Dec 7, 2018
|
@benesch Disabling rtti everywhere might be a small size / perf win. I didn't pull hard on the |
|
Ack. We should ditch cryptopp anyway. We can’t upgrade it because they dropped support for CMake builds in the next version, and their non-CMake build system doesn’t support out of tree builds. |
What would replace it? |
|
OpenSSL/LibreSSL would be my pick.
…On Fri, Dec 7, 2018 at 10:14 AM Peter Mattis ***@***.***> wrote:
We should ditch cryptopp anyway.
What would replace it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#32931 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA15IEMRFE1sA8qi8cfkFKTujoTKSazsks5u2oXZgaJpZM4ZImA6>
.
|
Pass `USE_RTTI=1` to the RocksDB build. 5.13 was built with rtti enabled (there was no way to disable it), but 5.17.2 defaults to disabling rtti. Unfortunately, the rest of our C++ dependencies build with rtti enabled and C++ requires consistently specifying `-fno-rtti` for all compilation, otherwise you get strange `undefined reference to typeinfo` errors at link time. At least one of our C++ dependencies (cryptopp) does not allow easily disabling usage of rtti. Verified that the `RocksDBDeleteRangeIterate` benchmark was unchanged which indicates the RocksDB delete range patches are in effect. Release note: None
petermattis
force-pushed
the
pmattis/bump-rocksdb
branch
from
a6e96b2
to
819183f
Compare
|
bors r=benesch |
craig bot
pushed a commit
that referenced
this pull request
Dec 7, 2018
32931: c-deps: bump RocksDB from 5.13 to 5.17.2 r=benesch a=petermattis Pass `USE_RTTI=1` to the RocksDB build. 5.13 was built with rtti enabled (there was no way to disable it), but 5.17.2 defaults to disabling rtti. Unfortunately, the rest of our C++ dependencies build with rtti enabled and C++ requires consistently specifying `-fno-rtti` for all compilation, otherwise you get strange `undefined reference to typeinfo` errors at link time. At least one of our C++ dependencies (cryptopp) does not allow easily disabling usage of rtti. Verified that the `RocksDBDeleteRangeIterate` benchmark was unchanged which indicates the RocksDB delete range patches are in effect. Release note: None Co-authored-by: Peter Mattis <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
USE_RTTI=1to the RocksDB build. 5.13 was built with rttienabled (there was no way to disable it), but 5.17.2 defaults to
disabling rtti. Unfortunately, the rest of our C++ dependencies build
with rtti enabled and C++ requires consistently specifying
-fno-rttifor all compilation, otherwise you get strange
undefined reference to typeinfoerrors at link time. At least one of our C++dependencies (cryptopp) does not allow easily disabling usage of rtti.
Verified that the
RocksDBDeleteRangeIteratebenchmark was unchangedwhich indicates the RocksDB delete range patches are in effect.
Release note: None