storage: muck with TestGossipHandlesReplacedNode #32697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was using manual replication, although it didn't have any good reason to do so. What it does care about is having all the data be replicated before it does something, but that's the case after cluster startup with regular replication too. The test used to take 2.2s, now it takes 3s. Not sure why, but in any case I'm trying to speed up cluster creation separately, so hopefully the delta with go away. Even with the delta, I think the test is better the more vanilla it is. And I've also skipped the test for testshort. Release note: None
|
This change is |
|
bors r+
…On Wed, Nov 28, 2018 at 6:30 PM Alex Robinson ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32697 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXBcWQ_oUaJnMjjhwnA5yO-iWSEY1gbks5uzxyfgaJpZM4Y4lyl>
.
|
craig bot
pushed a commit
that referenced
this pull request
Nov 28, 2018
32697: storage: muck with TestGossipHandlesReplacedNode r=andreimatei a=andreimatei The test was using manual replication, although it didn't have any good reason to do so. What it does care about is having all the data be replicated before it does something, but that's the case after cluster startup with regular replication too. The test used to take 2.2s, now it takes 3s. Not sure why, but in any case I'm trying to speed up cluster creation separately, so hopefully the delta with go away. Even with the delta, I think the test is better the more vanilla it is. And I've also skipped the test for testshort. Release note: None Co-authored-by: Andrei Matei <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was using manual replication, although it didn't have any good
reason to do so. What it does care about is having all the data be
replicated before it does something, but that's the case after cluster
startup with regular replication too.
The test used to take 2.2s, now it takes 3s. Not sure why, but in any
case I'm trying to speed up cluster creation separately, so hopefully
the delta with go away. Even with the delta, I think the test is better
the more vanilla it is.
And I've also skipped the test for testshort.
Release note: None