storage: fix TestApplyPaginatedCommittedEntries, use MaxCommittedSizePerReady #32429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
approved these changes
Nov 16, 2018
There was a problem hiding this comment.
LGTM
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
bors r+ |
Build failed |
|
#32149 flaked. bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 16, 2018
32429: storage: fix TestApplyPaginatedCommittedEntries, use MaxCommittedSizePerReady r=nvanbenschoten a=nvanbenschoten I forgot to point 4787e3c towards this test. With that change, the test was passing even without the corresponding fix. This commit changes the test to also adopt `RaftMaxCommittedSizePerReady` so that it fails again without the fix from 38b4827. Release note: None Co-authored-by: Nathan VanBenschoten <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to point 4787e3c towards this test. With that change, the test
was passing even without the corresponding fix. This commit changes the
test to also adopt
RaftMaxCommittedSizePerReadyso that it fails againwithout the fix from 38b4827.
Release note: None