roachtest: use high connect timeout in election test #31723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible the default of 5s is simply too tight, but as an easy indication for that we can see what total duration the test takes assuming it gets plenty of time to connect. Closes cockroachdb#31615. Release note: None
petermattis
approved these changes
Oct 23, 2018
|
bors r=petermattis |
craig bot
pushed a commit
that referenced
this pull request
Oct 23, 2018
31723: roachtest: use high connect timeout in election test r=petermattis a=tschottdorf It's possible the default of 5s is simply too tight, but as an easy indication for that we can see what total duration the test takes assuming it gets plenty of time to connect. Closes #31615. Release note: None Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible the default of 5s is simply too tight, but as an easy
indication for that we can see what total duration the test takes
assuming it gets plenty of time to connect.
Closes #31615.
Release note: None