storage: do not share an error across proposals #31631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
Replica.cancelPendingCommandsLocked was sharing an error across multiple proposals. This is problematic because Store.Send mutates Error.Now. Fixes cockroachdb#31535 Fixes cockroachdb#30483 Release note: None
|
This change is |
|
I'm |
|
25m without a reproduction while previously this was reproducing in 5-10m. bors r=benesch |
craig bot
pushed a commit
that referenced
this pull request
Oct 19, 2018
31631: storage: do not share an error across proposals r=benesch a=petermattis Replica.cancelPendingCommandsLocked was sharing an error across multiple proposals. This is problematic because Store.Send mutates Error.Now. Fixes #31535 Fixes #30483 Release note: None Co-authored-by: Peter Mattis <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replica.cancelPendingCommandsLocked was sharing an error across multiple
proposals. This is problematic because Store.Send mutates Error.Now.
Fixes #31535
Fixes #30483
Release note: None