release-2.1: distsql: don't use sortTopK when filter is present #31190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Oct 10, 2018
The sorter was producing incorrect results when both a limit and a filter were applied. We can't use sortTopK in this case since some results may be filtered out in post-processing. Note this scenario is somewhat rare because typically the filter would be pushed down below the sort. The issue was observed when selecting from the result of a SHOW TRACE. Also removed a bit of dead code. Fixes cockroachdb#31163 Release note: None
solongordon
force-pushed
the
backport2.1-31189
branch
from
7a4ca02 to
cf5020d
Compare
jordanlewis
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #31189.
/cc @cockroachdb/release
The sorter was producing incorrect results when both a limit and a
filter were applied. We can't use sortTopK in this case since some
results may be filtered out in post-processing. Note this scenario is
somewhat rare because typically the filter would be pushed down below
the sort. The issue was observed when selecting from the result of a
SHOW TRACE.
Also removed a bit of dead code.
Fixes #31163
Release note: None