build: install go 1.10 on TC agents #30453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We really want 1.11, but it isn't available yet. Relevant for go-test-teamcity in which I accidentally used a go1.10+ feature and broke nightly stress: > ../go-test-teamcity/main.go:254:5: dec.DisallowUnknownFields undefined (type *json.Decoder has no field or method DisallowUnknownFields) These things are bound to happen again in the future, so avoid them. Release note: None
|
This change is |
benesch
approved these changes
Sep 20, 2018
There was a problem hiding this comment.
Hmm, that PPA looks pretty unmaintained. Might be worth switching to just downloading the pre-compiled Linux binaries from golang.org. LGTM in the meantime though.
It's safe to build the new TC agent image; they won't switch over until you update the TC agent config. But yeah, at that point you're just praying that nothing breaks. Typically we do that late at night.
|
Ok, merging this. And then, I assume, I click the "Rebuild TeamCity Agent Image" job? And if that goes through, we'll have to figure out the switchover timing (I'll probably just do it in my AM). |
|
bors r=benesch |
craig bot
pushed a commit
that referenced
this pull request
Sep 26, 2018
30453: build: install go 1.10 on TC agents r=benesch a=tschottdorf We really want 1.11, but it isn't available yet. Relevant for go-test-teamcity in which I accidentally used a go1.10+ feature and broke nightly stress: > ../go-test-teamcity/main.go:254:5: dec.DisallowUnknownFields undefined (type *json.Decoder has no field or method DisallowUnknownFields) These things are bound to happen again in the future, so avoid them. @benesch suggestions on testing this other than merge-and-pray? Release note: None Co-authored-by: Tobias Schottdorf <[email protected]>
|
Yep, SGTM.
…On Wed, Sep 26, 2018 at 8:31 AM Tobias Schottdorf ***@***.***> wrote:
bors r=benesch
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30453 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA15IMwrVa7DWH5PWHTMld-kJG0OeT6dks5ue3OxgaJpZM4WxujE>
.
|
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really want 1.11, but it isn't available yet.
Relevant for go-test-teamcity in which I accidentally used a go1.10+
feature and broke nightly stress:
These things are bound to happen again in the future, so avoid them.
@benesch suggestions on testing this other than merge-and-pray?
Release note: None